Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies #12868 - fixes EOL date on asset creation #12917

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 26, 2023

This just applies PR #12868 to develop. There were a lot of unnecessary (more recent) changes that didn't belong in there, so this just seemed easier.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 19554a7 into develop Apr 26, 2023
3 of 4 checks passed
@snipe snipe deleted the fixes/applies_pr_12868 branch April 26, 2023 06:40
@what-the-diff
Copy link

what-the-diff bot commented Apr 26, 2023

PR Summary

  • Mandatory purchase_cost field
    The purchase_cost field is now required for both the API and web interface, ensuring accurate cost tracking.
  • Default asset EOL date
    If no asset end-of-life (EOL) date is provided, a default value will be set based on warranty months or manufacturer's suggested EOL, improving lifecycle management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant