Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #12946 - warranty lookup url was not nullable #12950

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Fixed #12946 - warranty lookup url was not nullable #12950

merged 1 commit into from
Apr 29, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 29, 2023 •
edited

Fixed an issue which made warranty lookup field required. Fixes #12946

@snipe
Fixed #12946 - warranty lookup url was not nullable
aa814cf 
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 4c27b65 into develop Apr 29, 2023
4 checks passed
@what-the-diff
Copy link

what-the-diff bot commented Apr 29, 2023

PR Summary

  • Changed order of rules in warranty_lookup_url
    The rule order was modified to fix an error when validating a URL starting with http:// or https:// and having no value (e.g. '').
  • Moved 'nullable' rule to the end
    'nullable' rule's position was adjusted to prevent validation errors.

@snipe snipe deleted the fixes/warranty_lookup_validation branch April 29, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@snipe