Fixed Error 500 after sign and accept asset

[inietov]

Description

A customer reported that when a user accepts an Asset a 500 is triggered.

I found that this was happening because the asset that is being assigned have associated a model that is soft-deleted. Which is something that doesn't supposed to happen. I discovered that using the API is possible to assign a model that doesn't exist when creating a new asset. So instead of patching the already occurred error I fix the root cause in the API.

I'm also adding a little conditional to the code retrieving the model name, so it doesn't hard crashes to users that already have models soft-deleted assigned to their assets, but that shouldn't be a problem from now on.

Fixes internal freshdesk 35225

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.2
• MySQL version: 8.0.31
• Webserver version: PHP Dev Server
• OS version: Debian 11

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Added model existence check
  The addition of a check helps in verifying if the model exists.
• Error handling for non-existent models
  In case the model doesn't exist, an error message is displayed and the function exits early, preventing further unnecessary processing.

[snipe]

Wouldn't it be better to solve this via the validation rules?

We currently have 'model_id' => 'required|integer|exists:models,id',

[inietov]

Wouldn't it be better to solve this via the validation rules?

We currently have 'model_id' => 'required|integer|exists:models,id',

That rule considers soft-deleted items as existent. laravel/framework#1820 https://laracasts.com/discuss/channels/general-discussion/validator-rule-for-exists-and-not-soft-deleted-row

But I can try to add a custom validator, or tweaking the rule... let me see what I can do then :).

[snipe]

Thanks, @inietov! I'll merge this one for now just to resolve the issue, but I'd definitely love to find out if we can handle this via validator.