Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed color differences in dark themes #12966

Merged
merged 9 commits into from
May 3, 2023
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented May 2, 2023

Description

This fixes miscellanous color problems in the dark themes. Some columns in tables were different colors those have been correct as well as the following:

Below Custom fields were a bit unreadable. this makes all custom field tags more legible across the board
Before:
image
After:
image

Below the action buttons located everywhere were receiving different shades of color that were intended for links only. Now they stay perma-white
Before:
image
After:
image
The Black dark theme notifications when hovered upon were unreadable
Before:
image
After:
image

Fixes #SC-23161

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner May 2, 2023 22:24
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23161: Misc errors in dark skins.

@what-the-diff
Copy link

what-the-diff bot commented May 2, 2023

PR Summary

  • New button class for action buttons
    Added a new button class to improve the UI for action buttons.
  • Improved readability for dark themes
    Adjusted colors in dark skins (orange, red, yellow) for better readability and consistency.
  • Fixed visibility of custom fields in dark themes
    Resolved an issue where custom fields were not displayed on models or fieldset pages while using dark themes.

@snipe snipe merged commit 466c2fd into snipe:develop May 3, 2023
4 checks passed
@snipe snipe changed the title fixed color differences in dark themes Fixed color differences in dark themes May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants