Fixed Notes field doesn't get populate when creating/updating assets via Importer [sc-23222]

[inietov]

Description

A long time ago, in a galaxy far far away... sorry, today is Starwars day. But yeah, some time ago we decided to separate Asset Notes from Model Notes, before that we only have one general Notes field, but this caused that every time a user populate that field the Asset notes field and the Model notes field get duplicated (more details in #10735).

I think that separation got lost in the Great Importer Livewirefication, because the backend expects that column mapping, but they aren't in the Livewire columns. So this PR just put those columns back.

Fixes [sc-23222]

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.2
• MySQL version: 8.0.32
• Webserver version: PHP Dev Server
• OS version: Debian 11

[shortcut-integration]

This pull request has been linked to Shortcut Story #23222: When using csv import to update assets, notes field does not update.

[what-the-diff]

PR Summary

• Removed notes from accessories array
  Cleaned up and simplified code by removing unnecessary notes from accessories.

• Added notes to assets and consumables arrays
  Enhanced functionality by including notes in the assets and consumables for better data organization.

• Updated 'notes' key in users array
  Improved clarity by changing the 'notes' key value from an empty string to "Notes" in the users array.

• Added 'notes' key/value pair in locations array
  Added the ability to store notes in locations, enhancing data management and organization.

[snipe]

@uberbrady I might well be misunderstanding how this is supposed to work, but shouldn't leaving notes in the "everything" array be better? I thought the whole point was to keep repeated things that everything would have in that generic array, and then each specific object gets its own for whatever uncommon fields they have?

[inietov]

Not uberbrady, but the thing is that for Assets we need the Asset Notes and Model Notes, and if we add the Notes field that can be more confusing since it wouldn't have any effect. Is there a way to put the Notes field in the general array and then not showing it for imports of type Assets?

[mirktmirkt]

Hello,

I have tested these Docker images:
https://hub.docker.com/layers/snipe/snipe-it/latest/images/sha256-dcc31730cb2682c5ca1793eeaa75e3b6a4fe5dd94c168c842e41456a37fd60a6?context=explore
https://hub.docker.com/layers/snipe/snipe-it/develop/images/sha256-15a1574926b2aead35b8261608ba5feead347ff3bd33ea40b757726e114c3978?context=explore

"Notes" still are not populated on cvs import.. Isn't fix is applied in these Docker images?

Thank you,
mirkt

Docker

Docker

[szecsib]

HI SnipeIT team,

We have the same issue with Version v6.1.1-pre - build 10778 (master).
I'm used dockerhub to deploy this version to our docker environment. I tried to overwrite the app/Http/Livewire/Importer.php with this fix but it's still missing the Asset notes after the import process. Could you give us feedback or other method to import the asset notes? Is it possible the fix is ready in developer branch but it's not in the docker version of the app?

BR,
Balazs