Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons on the Accessory View Page #12982

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented May 8, 2023

Buttons have been added to the view page for accessories. This removes the dropdown as it would be duplicate code (including an option in the dropdown that was already a button). A delete button has also been added. This brings this page more in alignment with other top level model view pages, such as asset.

The delete button will be unclickable with error tooltip if an accessory of that type is still checked out.
Screenshot 2023-05-08 at 2 43 50 PM

Once it is clickable, selecting delete will present a popup, informing the user that the deletion is non-reversable.
Screenshot 2023-05-08 at 2 44 08 PM

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally on test instance

Checklist:

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23214: Accessories sidebar buttons.

@what-the-diff
Copy link

what-the-diff bot commented May 8, 2023

PR Summary

  • Improved accessory deletion message
    Added a clearer warning message for users before deleting an accessory, emphasizing that the action is irreversible.

  • Accessory view page layout updates
    Adjusted the layout of buttons on the accessories view page for better consistency with the rest of the application and created more space for potential future additions.

  • Code refactoring for checking items in/out
    Separated the code for checking items in and out into different files, making it easier to include these functionalities across the application without duplicating code.

@snipe snipe merged commit 2d5da67 into snipe:develop May 9, 2023
4 checks passed
@akemidx akemidx deleted the feature/sc-23214 branch April 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants