Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warranty confirmation to asset maintenance table #13158

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jun 12, 2023

Description

Adds a response if an asset under maintenance is covered/improved by a warranty in the table view of maintenance requests.

image

Fixes #13152

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jun 12, 2023

PR Summary

  • Added new column to asset maintenance report
    The report now displays an additional column with relevant information.
  • Updated transformer for the report to include is_warranty field
    The report will now correctly show whether an asset is under warranty or not.

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the trueFalseFormatter here instead to make it more consistent with our other views?

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to request changes here not approve. :(

@Godmartinz
Copy link
Collaborator Author

@snipe Done 🙂

@snipe
Copy link
Owner

snipe commented Jun 13, 2023

We'll probably also want to add that is_warranty field to the API controller in the allowed columns so it can be sorted on

@snipe snipe changed the title adds warranty confirmation to asset maintenance table Added warranty confirmation to asset maintenance table Jun 13, 2023
@Godmartinz Godmartinz requested a review from snipe June 14, 2023 16:26
@snipe snipe merged commit 21a27f4 into snipe:develop Jun 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants