Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to checkbox layout in general settings blade #13501

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 22, 2023

On a customer call today I noticed that a few of the checkboxes in the General Settings page were not re-fitted to the new (non-iCheck) layout. This fixes that.

Before

Screenshot 2023-08-22 at 2 10 09 PM

After

Screenshot 2023-08-22 at 2 10 19 PM

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 3da21e7 into develop Aug 22, 2023
4 of 5 checks passed
@snipe snipe deleted the fixes/checkbox_layout_in_settings branch August 22, 2023 13:12
@what-the-diff
Copy link

what-the-diff bot commented Aug 22, 2023

PR Summary

  • Removal of CSS Style for Checkbox Label
    The specific style applied to checkboxes through CSS has been removed. This could affect the appearance and behavior of checkboxes on the interface.

  • Addition of Label Element with form-control and aria-label Attributes
    New label elements have been added, designed with accessibility in mind. The form-control class helps in standardizing the appearance and behavior of the element across different platforms, while aria-label improves interaction for users with screen readers.

  • Addition of Label Element with form-control Class
    Another label element only classified under form-control has been added. It aids in harmonizing form behavior and appearance across various systems, enhancing the overall user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant