Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify upload messaging, handle -1% error #13605

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Simplify upload messaging, handle -1% error #13605

merged 5 commits into from
Sep 14, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 14, 2023

This doesn't really fix the issue as such, but it makes it look less terrible and confusing. I don't think the % uploaded ever actually worked properly (or files uploaded fast enough that we never saw the % increase). We can always revisit this and try to get the % actually working correctly if we want to.

Screen.Recording.2023-09-14.at.9.54.19.PM.mov

Signed-off-by: snipe <snipe@snipe.net>
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23183: Import upload -1% error message.

@what-the-diff
Copy link

what-the-diff bot commented Sep 14, 2023

PR Summary

  • Enhanced Language Localization
    The language localization in general.php was improved through the modification of values for notification_success, notification_warning, and notification_info. To provide better user feedback, the system now includes messages for upload_error and percent_complete.

  • UI Updates in Importer View
    Updates were applied to the importer.blade.php file to refine the user interface. This involved modifying certain HTML elements such as progress-container and progress-bar, and adjusting the progress_message formatting. Furthermore, the upload_error message has been improved to include an animated icon for better error visibility.

  • Improved Notification Formatting
    For better readability and clarity, the text alert layout in notifications.blade.php was modified to incorporate a colon after each error or success notification received by the user. This adds a clear separation between the notification type and the subsequent message.

@snipe snipe requested review from uberbrady and marcusmoore and removed request for uberbrady September 14, 2023 20:57
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe
Copy link
Owner Author

snipe commented Sep 14, 2023

I just pushed up a small layout change that should make the warnings appear a little nicer when an import (not upload) fails. The warning box container now has the correct padding on the sides.

Before

Screenshot 2023-09-14 at 10 05 20 PM

After

Screenshot 2023-09-14 at 10 06 05 PM

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe
Copy link
Owner Author

snipe commented Sep 14, 2023

(Okay, I'm done for real now lol)

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Some really nice improvements - the : thing was particuarly subtle. Good choice.

@snipe snipe merged commit a013ddf into develop Sep 14, 2023
8 checks passed
@snipe snipe deleted the bug/sc-23183 branch September 14, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants