Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher contrast for green dark skin #13915

Closed
wants to merge 1 commit into from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 21, 2023

Description

Changes the color for table row so that all rows are visible.
image

Fixes #sc-24068

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 21, 2023

PR Summary

  • Background Color Adjustment for Striped Table Rows
    The striped rows in tables will now use a slightly different background color. This can improve the readability of data and overall user experience when navigating such tables.

@snipe
Copy link
Owner

snipe commented Nov 22, 2023

@Godmartinz can you retarget this to develop please?

@snipe snipe changed the title change color variable for table rows Higher contrast for green dark skin Nov 23, 2023
snipe added a commit that referenced this pull request Nov 23, 2023
Applies #13915 to develop

Signed-off-by: snipe <snipe@snipe.net>
snipe added a commit that referenced this pull request Nov 23, 2023
…velop

Higher contrast on green dark skin (#13915 for develop)
@snipe
Copy link
Owner

snipe commented Nov 23, 2023

I made a new PR with this fix for develop, since it's a holiday weekend :) Happy turkey day!

@snipe snipe closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants