Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jquery-ui-bundle #13966

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Removed jquery-ui-bundle #13966

merged 3 commits into from
Dec 15, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR removes jquery-ui-bundle and replaces it with the existing jquery-ui javascript.

Removing jquery-ui-bundle, which was last updated to 1.12.1, and using jquery-ui directly means that, even though the project is in maintenance mode, we can bump to 1.13.2 and receive any additional fixes in the future.

The removal without replacement of the "./node_modules/jquery-ui-bundle/jquery-ui.css" line doesn't seem to have an affect on the front end. I believe this is because AdminLTE also requires jquery-ui. This probably means we could remove it from our package.json but I quickly tried it and broke javascript. Let me know if I should explore it more.

I went through the process of juggling branches while building assets to make sure nothing broke but please double-check my work.

Type of change

  • Dependency update

@probot-autolabeler probot-autolabeler bot added dependencies Pull requests that update a dependency file frontend javascript skins labels Nov 29, 2023
Copy link

This pull request has been linked to Shortcut Story #24120: Figure out why we still need jQuery-ui-bundle.

Copy link

what-the-diff bot commented Nov 29, 2023

PR Summary

  • Update of integrity hashes
    Several integrity hashes have been updated in package-lock.json file, which is an automatically generated file used to capture and track the exact version of installed dependencies. This change will ensure better security and integrity of the resources used in the project.

  • Removal of unnecessary dependency
    The dependency "jquery-ui-bundle" was removed from package.json. This change contributes to the project by removing code that is no longer needed or used, making the project cleaner and faster to load.

  • Change in the import path
    In webpack.mix.js, the file where we bundle our assets, the paths to import jQuery UI (useful for creating interactive elements on the web page) were updated. It now directly fetches from jquery-ui package instead of jquery-ui-bundle. As a result, the project will work with the standard jQuery UI package, reducing potential conflicts or mismatched versions issues that can occur with different package bundles.

@marcusmoore
Copy link
Collaborator Author

Friendly ping @snipe @uberbrady

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling stuff out of package.json is a universal GOOD. And Red diffs are the BEST diffs! But, besides that, I think that removing a package that even just has the appearance of security issues is important, all-around. I'm going to want to make sure that those checksum changes will still allow for installs to work correctly and don't introduce any new problems, and I'll want to take a quick breeze through the app to make sure everything still looks good, but I think this is great! Thanks for tracking all of this down, and getting this out there. I'm going to try and look at it today.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to resolve the conflicts in package-lock.json to get this to work, but I was able to run through all the main pages of the app and saw no JS errors. I think this is good! Thanks again for the fix!

@snipe snipe merged commit e3d6d48 into snipe:develop Dec 15, 2023
7 checks passed
@marcusmoore marcusmoore deleted the feature/sc-24120 branch December 18, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend javascript skins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants