Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed black dark theme, contrast issues etc #13976

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Corrects some contrast issues with the Black Dark theme

image image image image

Fixes #SC-24144

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

This pull request has been linked to Shortcut Story #24144: Low contrast on dark skins.

Copy link

what-the-diff bot commented Nov 29, 2023

PR Summary

  • Updated Main Text and Link Colors
    The color of the main text and links in the application has been modified to provide better visibility and readability.
  • Augmented Search Highlight Style
    The search highlight feature has been improved to assist users in easily locating their search terms within the site.
  • Removed Outdated Styling
    Certain older styles associated with links which were no longer needed have been removed to clean up the code and reduce complexity of the styling configuration.
  • Enriched Component Appearance
    The color scheme for options within the 'select2' component has been updated to enhance the visual experience.
  • Added Background Color for Important Tables
    Tables classified with a 'danger' status now have a distinctive background color, helping to draw attention to significant information.
  • Removed Unnecessary Newline
    An unnecessary newline at the end of the file has been removed to maintain better coding standards.

@snipe snipe changed the title fixes for the black dark theme, contrast issues etc Fixed black dark theme, contrast issues etc Nov 30, 2023
@snipe
Copy link
Owner

snipe commented Nov 30, 2023

Thanks! Can you check the other dark skins as well for similar issues?

@snipe snipe merged commit 42109dc into snipe:develop Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants