Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test suite for our LDAP implementation. The only way I was able to make it make sense to me was to add a special Mocking library that allows me to 'stub out' the actual LDAP calls. It's not particularly pretty, but it's at least a decent start to being able to be more confident about changes we make in the LDAP subsystem. There's also more work to do here, in that this doesn't carefully check the various values to ensure that they're all what we would expect. But, again, it's at least a decent start, that we can continue to beef up over time so we can be more confident about making bigger changes to the LDAP subsystem.