Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maintenances patch endpoint #14007

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixed maintenances patch endpoint #14007

merged 1 commit into from
Dec 7, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 7, 2023

This should resolve an unreported issue on the (existing but not documented) PATCH method on the maintenances endpoint. Previous behavior was that it would blank out fields if they were not present in the request (which is not what PATCH should be doing.)

Signed-off-by: snipe <snipe@snipe.net>
Copy link

Copy link

what-the-diff bot commented Dec 7, 2023

PR Summary

  • Simplified Data Assignment Process
    In the controller for "Asset Maintenances", the PR has introduced a more efficient way of assigning data to the 'AssetMaintenance' model using an operation called fill(). They've ensured that not all data can be assigned directly to protect from any unauthorized access by specifying a fillable property.

  • Enhanced Date Validations
    In 'AssetMaintenance', the start date and completion date fields now have additional checks to ensure the date is specified correctly. This helps in maintaining consistent datetime data and minimizes manual errors.

  • Language Support Updates
    More translation words have been added to the 'general' language file. It includes phrases for scenarios where an item is not available and permission for a particular action is denied. It also extends the support for the 'edit' operation, making the application more understandable and user-friendly.

@snipe snipe merged commit e483e91 into develop Dec 7, 2023
4 of 7 checks passed
@snipe snipe deleted the bug/sc-24315 branch December 7, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant