Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller icon size for activity reports, other action icons #14017

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 12, 2023

I was hoping we were controlling this via the fa-2x CSS styles, but I think we had opted to go a different route so we could have slightly more control over the font size. (fa styles kinda don't work that way.)

The larger icons didn't look too bad on the full activity report, but they felt a little clunky to me in tighter spaces, like the dashboard. I had initially liked the larger icon for emphasis, but it feels like it throws off the balance in retrospect.

Before

Screenshot 2023-12-12 at 1 01 09 AM

After

Screenshot 2023-12-12 at 1 00 54 AM

Related to the initial change in #13931.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit bbe5c7c into develop Dec 12, 2023
3 of 7 checks passed
@snipe snipe deleted the bug/sc-24323 branch December 12, 2023 01:02
Copy link

what-the-diff bot commented Dec 12, 2023

PR Summary

  • Adjusted Text Size Across Multiple Stylesheets
    The update modifies the font size in several primary style files, making the text in our application more compact and hopefully easier to read.

Copy link

This pull request has been linked to Shortcut Story #24323: Activity log icons are a little too large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant