Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model name and number to quickscan #14018

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 12, 2023

This PR adds model name and model number to the quick scan results table. I do worry that on smaller screens, this might get cramped, but when dealing with a large number of assets, the additional information could be useful.

The original request was also to include asset name, but I just don't see how we'd manage to fit that in there, and given the fact that many users don't even utilize asset names, this seemed like a good compromise.

Before

Screenshot 2023-12-12 at 4 24 26 AM

After

Screenshot 2023-12-12 at 4 22 07 AM

Fixes FD-39270

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Dec 12, 2023

PR Summary

  • Enhancements to AssetsController.php

    • The checkin function in AssetsController.php has been improved. Now, it includes more information about the asset and its model in the JSON response provided when this function is executed. This will provide more detailed data when assets are being managed.
    • Additionally, the PR adds a verification stage to the checkin function. It will now check if a particular piece of information about an asset's model is available before including it in the response.
  • Updates to quickscan-checkin-blade.php

    • Several additions have been made to the user interface that presents data. New table headers asset_model and model_no have been included in quickscan-checkin.blade.php. This means that users will be able to see more information about each asset.
    • The data in the table is also updated. It now displays asset tag, model, and model number for each entry to allow better identification and understanding.
    • The functionality for handling failed check-ins, handlecheckinFail, has also been improved. It can now manage new types of data (asset tag, model, and model number).
    • In cases of check-in failures, the table row that gets added includes more detailed information including the asset tag, model, model number and the specific error messages. This will provide users with more context about what went wrong.

@snipe
Copy link
Owner Author

snipe commented Dec 12, 2023

I suppose one way to handle the screen real estate is to make the form all on one line, and then the results table can span the whole page.

@snipe
Copy link
Owner Author

snipe commented Dec 12, 2023

Hm, in playing around with the form being on one line, it looks awfully clunky, specifically because of the notes field :(

@snipe snipe merged commit 068f64a into develop Dec 12, 2023
4 of 7 checks passed
@snipe snipe deleted the features/more_info_in_quickscan branch December 12, 2023 04:31
@brianhoganm
Copy link

brianhoganm commented Dec 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants