Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #14037 - record current time on accessory checkin #14042

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 15, 2023

Since accessory checkin (or chicken, as autocorrect would have it) allows you to specify a date, we were treating that datetime as a date field, without providing any hour information. This now takes the current time and appends it correctly.

Screenshot 2023-12-15 at 4 41 01 PM

Signed-off-by: snipe <snipe@snipe.net>
Copy link

This pull request has been linked to Shortcut Story #24356: Accessory check-in not recording the correct time.

@snipe snipe merged commit 05bc9f1 into develop Dec 15, 2023
7 checks passed
Copy link

what-the-diff bot commented Dec 15, 2023

PR Summary

  • Added Check-in Duration Variable
    This update introduces a new component known as checkin_hours which stores the duration for which a user stays after checking in.
  • Updated Check-in Time Calculation
    The checkin_at component, responsible for managing the exact check-in times, is also updated. It now takes into account the newly added checkin_hours value during its operations. This means, when you provide the duration of your stay, the system seamlessly includes it in calculating your check-in time. This will provide more accurate information about user's stay duration and can help in managing resources more effectively.

@snipe snipe deleted the bug/sc-24356 branch December 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant