Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email in License Seat Table #14051

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Dec 19, 2023

Description

Email address is added to the license seat view tab. Upon selecting the tab, a view of the email address for the user assigned to that license seat appears to the right of their name. This info will also be in the export if the export is made from the license view page.

SC24316
Ticket 39372

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test locally. New feature is only a view addition

Copy link

what-the-diff bot commented Dec 19, 2023

PR Summary

  • Enhancement in LicenseSeatsTransformer.php
    A new element was added to the 'assigned_user' array. This element corresponds to the 'email' of the user who is assigned the license. This enables the software to also display the user's email in the specified section, which can facilitate communication.

  • Update in LicensePresenter.php
    Made a new addition to the data table layout function for seats in the licensing area. A new array element was included that determines the user's email as a field and formats it appropriately ('emailFormatter'). This can make the presentation of users' emails more organized and readable in the table layout.

@snipe
Copy link
Owner

snipe commented Dec 23, 2023

This was in Unscheduled - I'm not sure this is a feature we want tbh. That table is already kind of cluttered. Let me think about it over the break tho.

@snipe snipe merged commit fff2141 into snipe:develop Jan 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants