Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ldap sync test table and table data from overflowing #14058

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This makes the ldap test sync table fixed so columns will not extend outside of the table and table data will not overflow as well.
image

Fixes #SC-24333

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Dec 19, 2023

PR Summary

  • Adjustment to the LDAP Test Results Table Layout
    The designated table in the LDAP testing results display now has a fixed layout and spans the full width of its container for improved visualization, as done in line 701 of the resources/views/settings/ldap.blade.php file.

  • Styling Update to Table Row Elements
    The rows of data in the LDAP results table now have a style update to prevent extra content from overflowing its container, enhancing the readability. The adjustment took place on line 729.

@Godmartinz
Copy link
Collaborator Author

@snipe anything need changing here?

@snipe snipe merged commit 5f8e637 into snipe:develop Jan 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants