-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize language codes, updated strings #14059
Conversation
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to take a deeper look at this from my local, since it's too hard to view the changes from GitHub. So far it looks great, but the one thing I think I'd like to ask for is the down()
migration in case we run into some kind of horrible problem that we need to back ourselves out of. I'll give a formal review once I've pulled it down though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get a handle on the contents of this by doing:
git diff --name-status develop |grep -v resources/lang
Once I did that, I was able to make sure I at least had a handle on what was changing.
I am so glad we are FINALLY un-screwing-up our language files - that's amazing!!!
This all looks extremely well-thought-out and thorough. It's a nasty change, but a necessary one.
I think the one change I'd like to ask for is the down()
migration as I mentioned previously. I feel like, especially with such a huge change, the ability to go 'back' to an old, known-good state should be critical, in case something goes terribly wrong. And with so much changing that is a distinct possibility. Regardless of that one small request, I think this looks great and is ready to go! Yay! I'm terrified!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮💨 this was a heavy lift!
I have some questions about potential safe-guards.
…ocalization_refactor Added back-migration for Big Locale Refactoring
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And wow, what a gorgeous back-migration we have - wow, that's some really brilliant code-writing, whoever did that! I think you addressed everything I was concerned with. I'm still a little worried about the rollout plan, but that's outside of the scope of this PR.
We default down to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little scary to say since the diff is massive but this looks good to me.
I had not intended for this to be a Whole Ass Thing, but this is an issue that's been bugging me and causing a ton of friction in our release cycle for years. Basically, when Laravel 4 was released, they (and therefore we) were using 2 letter codes for language. As time went on, we never updated to use a "more" correct 5-6 character code instead.
This meant that every time I downloaded translations from Crowdin, I had to rename directories, etc - which made releasing take hours longer than it should have. With this change, we should be able to just download those translations and go, which I cannot tell you how much I'm excited about. (Truly.)
This also adds a migration to update the settings table and the users table to use the new codes, and updates the dropdown.