Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Google Login prompt higher, made it bigger #14104

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 5, 2024

Makes the Google login button higher on the page and larger.

Screenshot 2024-01-05 at 3 00 57 PM

Fixes FB-39748

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 6ebbd2d into develop Jan 5, 2024
6 checks passed
@snipe snipe deleted the feature/google_login_more_prominent branch January 5, 2024 15:03
Copy link

what-the-diff bot commented Jan 5, 2024

PR Summary

  • Creation of a New CSS Class
    A new CSS class named .separator was introduced. This class is used to style a separator with centrally-placed text. It's utilized on the login page of our app.

  • Adjustments in Front-end Files to Accommodate .separator
    The styles specified in the .separator class were included in multiple CSS files such as app.css, all.css and in the less file overrides.less. These changes ensure the new characteristic defined by .separator can be accessed in various parts of our application.

  • Revision in JSON and CSS Files
    The versions of overrides.css and app.css files recorded in mix-manifest.json were updated to reflect their modifications. Having up-to-date versions helps in easy identification and reduces conflict among various versions.

  • Addition of New Translation
    The files auth/general.php and general.php were revised to include a new translation for the term "or". This change enhances our app's capability to cater to different user languages.

  • Modification of Login Interface
    The login interface (login.blade.php file) now includes a Google login button. The .separator class has also been put to use here for better representation of the option "or", providing users a choice to log in either via their Google account or other means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant