Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license expiration date in "view asset" #14115

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Added license expiration date in "view asset" #14115

merged 1 commit into from
Jan 9, 2024

Conversation

mauro-miatello
Copy link
Contributor

I've added the expiration date of the license associated with an asset in hardware/ID#software, it is useful to see all of them on the asset page instead of having to open the license details page. I've also fixed a space formatting issue.

Description

It's a simple change, only added the license expiration date in the asset view and fixed a space layout issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've changed it and tested it in my local environment

Test Configuration:

  • PHP version: 8.0.30
  • MySQL version: MariaDB 10.3.38
  • Webserver version: Apache 2.4.58
  • OS version: Ubuntu 20.04.6 LTS

Checklist:

I've added the expiration date of the license associated with an asset in hardware/ID#software, it is useful to see all of them on the asset page instead of having to open the license details page. I've also fixed a space formatting issue.
Copy link

what-the-diff bot commented Jan 9, 2024

PR Summary

  • Warning for Outdated Assets
    A brand-new feature has been added that displays a noticeable warning symbol whenever an asset has reached its end of life. This means if the asset's expiry date is before the current date, a unique sign, an exclamation triangle, will be displayed to highlight this status.

  • Added License Expiry Information
    The licenses table has been extended to include a new column showing the expiration date of each license. Such an update aids in effectively managing renewals and maintaining an overview of the licenses' lifespan.

Please note the changes in code are done in the resources/views/hardware/view.blade.php file.

@mauro-miatello
Copy link
Contributor Author

I've done a new PR in place of #14106
Hope to be ok, sorry for the previous wrong one.
This is my first PR, please be kind :P

@snipe
Copy link
Owner

snipe commented Jan 9, 2024

This is m much better thanks :)

@snipe snipe merged commit 10ee6ee into snipe:develop Jan 9, 2024
2 checks passed
Copy link

welcome bot commented Jan 9, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants