Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Microsoft Teams Notifications #14153

Merged
merged 15 commits into from
Jan 25, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

Microsoft Teams is an option now in the integrations settings page:
image
This option adds better notification details for Microsoft Teams now.
image
image

This currently only supports one channel for messaging check-ins and check-outs.

Fixes #10972

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Jan 23, 2024

PR Summary

  • Introduction of Microsoft Teams integration
    A significant part of this PR involves the addition of Microsoft Teams integration throughout the system. A new toMicrosoftTeams method has been introduced in multiple classes under the App\Notifications folder. These additions extend the system's functionality to facilitate communication via Microsoft Teams.

  • Improvements to the Webhook Settings UI
    Updated Slack settings form to include Microsoft Teams as an option in the webhook section. The settings now adjust dynamically based on the kind of webhook selected. Additionally, a feature to test the webhook, specifically crafted for Microsoft Teams, has been included.

  • Enhancements to CheckinAccessoryNotification and CheckoutAccessoryNotification
    The respective listeners for both check-in and check-out options have been updated to conditionally send notifications to Slack. This addition further enhances communication by extending the notification system to the Slack platform.

  • Updation of composer.json
    A new dependency, laravel-notification-channels/microsoft-teams, has been added to the composer.json, enhancing the software's compatibility and functionality with Microsoft Teams.

  • Language Resource Extensions
    The resources/lang/en-US/mail.php has undergone significant changes. These include the addition of new notifications, confirmations, and reports for various asset transactions, further enriching the system’s communication capabilities.

  • Localization
    In the spirit of increased accessibility, a new translation key, ms_teams, has been added to resources/lang/en-US/admin/settings/general.php.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted the translations to be alphabetized

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid start but a few things to update before merging 😄

app/Notifications/CheckoutAssetNotification.php Outdated Show resolved Hide resolved
app/Notifications/CheckoutAccessoryNotification.php Outdated Show resolved Hide resolved
app/Notifications/CheckinAccessoryNotification.php Outdated Show resolved Hide resolved
app/Notifications/CheckinAssetNotification.php Outdated Show resolved Hide resolved
@mauro-miatello
Copy link
Contributor

Awesome ! I would really like to have the same feature for google workspace chat ;) !

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few translations needed

app/Http/Livewire/SlackSettingsForm.php Outdated Show resolved Hide resolved
app/Http/Livewire/SlackSettingsForm.php Outdated Show resolved Hide resolved
@Godmartinz
Copy link
Collaborator Author

changes have been applied and translations have been added 👍 . Thanks for the extra eyes

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing I just noticed.

app/Notifications/CheckinAccessoryNotification.php Outdated Show resolved Hide resolved
@snipe snipe merged commit ab926f2 into snipe:develop Jan 25, 2024
8 checks passed
@ZoXx
Copy link

ZoXx commented May 6, 2024

Hello everyone,
We have set up the webhook in Teams and linked it via Snipe-IT but do not receive a notification at check-in and check-out.
Does this need to be configured additionally?

@ZoXx
Copy link

ZoXx commented May 12, 2024

nobody? :(

@Godmartinz
Copy link
Collaborator Author

@ZoXx hi, can you elaborate a bit for me: Does the "Test integration" in settings work? Does the notification not show up for Assets, Components, Accessories, or Licenses?

Also this would be better suited for the git community if we discussed this under Issues rather on a closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants