Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved URL string to general #14158

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Moved URL string to general #14158

merged 2 commits into from
Jan 24, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 24, 2024

This just moves the url translation string that was duplicated in a few places to be in general.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 684264d into develop Jan 24, 2024
5 of 6 checks passed
@snipe snipe deleted the fixes/moved_url_string_again branch January 24, 2024 14:48
Copy link

what-the-diff bot commented Jan 24, 2024

PR Summary

  • Refactored URL Labelling Across Files
    The term 'URL' was being defined separately in multiple file locations. It's now moved to a central location in resources/lang/en-US/general.php, leading to a uniform URL label across the platform.
  • Optimized Label Text in Manufacturer and Supplier Edits
    The label text for 'URL' in both the manufacturer and supplier edit panels, previously sourced from their respective directories, are now uniformly referenced from general.url, improving code reusability.
  • Standardized Checkbox Label Text
    The checkbox label text for URL on the custom report page is now referenced from general.url instead of the previous manufacturer-specific label, ensuring consistency.
  • Optimized Column Header in Supplier Views
    The column header for URL in supplier view tables was labeled using a supplier-specific definition. It now uses the general label leading to a more consistent user experience.

By these changes, future updates to this label will be easier to implement and provide a uniform experience across different sections of the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant