New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new validator for custom field checkboxes and fix asset model default updates #14369
Conversation
This pull request has been linked to Shortcut Story #24343: Validation error when using checkboxes on default custom fields models. |
PR Summary
|
@snipe friendly poke |
per @snipe adding some validation for radio buttons as well, please hold |
alright, added @snipe |
Description
This adds a new validator for checkboxes, as well as adding support for submitting an array for checkbox options through the API.
This also removes the option to encrypt new checkbox custom fields after a conversation with the team.
Tests are included, but not working yet. After a conversation with @marcusmoore there's an issue with the AssetModel factory (if I'm remembering correctly) preventing custom fields from being properly testable, I left the tests in the PR but commented to serve as a reminder to get that fixed and leave them there for future un-commenting.
****Removed the commented tests because they were making all tests fail for some reason, I have them locally so we can re-implement when the factory issue is resolved.
Fixes #SC-24343
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration: