Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 1dbarcodes to populate based on settings #14380

Merged
merged 3 commits into from Mar 7, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This applies a check to see if alt_barcodes are enabled or not. and it populates the label accordingly.
Getting rid of this warning:
image

Fixes #FD-40875

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Introduction of a Condition in Label Processing
    The Label.php now integrates a new verification state to determine if the alternate barcode system is active or not, with its associated functions only activated when necessary.
  • Change in Barcode Type Assignment Timing
    The point of assigning $barcode1DType was also altered. It now falls under the newly implemented condition, thus it only occurs when the alternate barcode system is enabled, increasing efficiency.

@Godmartinz Godmartinz changed the base branch from master to develop March 6, 2024 23:14
@snipe snipe merged commit 58bf036 into snipe:develop Mar 7, 2024
8 checks passed
@snipe snipe added the labels label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants