Adds a minimal amount of validation around asset_tags in AssetsController

[marcusmoore]

Description

This PR introduces a tiny bit of validation around the asset_tags field in the AssetsController's store method.

We saw a few exceptions pop up in the demo, most likely some someone manually messing with the form, and this gives a little more protection from 500s being thrown from this method.

Type of change

• Bug fix (ish) (non-breaking change which fixes an issue)

[what-the-diff]

PR Summary

• Enforced Array Validation on asset_tags in store()
  • Updated the store() method in the AssetsController.php file with a new validation rule.
  • This rule checks that the asset_tags field is populated and is of array type before an asset is stored. This aims to avoid issues related to missing asset_tags.
  • This validation is only applied during the creation of new assets and won't affect the asset updating process.

[snipe]

I think we use that form handler elsewhere (accessories, etc) so I'm not sure we can insist on asset tags here.

[marcusmoore]

I think we use that form handler elsewhere (accessories, etc) so I'm not sure we can insist on asset tags here.

@snipe The Rollbar we were seeing was because $asset_tags was null and "must be of type Countable|array" on this line so it seems like it is actually required right?

snipe-it/app/Http/Controllers/Assets/AssetsController.php

Line 115 in a184b4e

for ($a = 1; $a <= count($asset_tags); $a++) {

[snipe]

We do in that controller, yes, but your edits are to the ImageUploadRequest, which we use in other (non-asset) places.

[snipe]

Nope, never mind - I misread the PR. Sigh.

[marcusmoore]

@snipe friendly ping