Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #14460 add avif format #14465

Merged
merged 3 commits into from Mar 20, 2024
Merged

Added #14460 add avif format #14465

merged 3 commits into from Mar 20, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 20, 2024

This adds support for avif image files.

I used this file for testing.

true.avif.zip

This adds #14460

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Mar 20, 2024

PR Summary

  • Enhanced Image Type Support in Helper.php

    • This PR extends the compatibility of our software to now accept AVIF type image files and properly classify WEBP and AVIF as legitimate image types. This includes verifications and displaying of these files inline with the rest of our offerings.
  • ImageUploadRequest.php Adjustments

    • This file has been modified to accept AVIF images in our image and avatar uploads. Additionally, this update results in cleaner code as debug logging statements, which were redundant, are now removed.
  • UploadFileRequest.php Improvements

    • The AVIF files can now be uploaded as general files with this change. This allows users more flexibility with the type of files they'd like to use.
  • Image-upload.blade.php Updates

    • In an effort to make our user interface more accommodating to varied file types, the file input now accepts AVIF as a valid image type.

@snipe snipe requested a review from uberbrady March 20, 2024 12:32
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - just do make sure that you update that comment and I think it'll be good to go.

app/Http/Requests/ImageUploadRequest.php Outdated Show resolved Hide resolved
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 52551da into develop Mar 20, 2024
8 checks passed
@snipe snipe deleted the features/14460_add_avif_format branch March 20, 2024 12:39
@tglassburn
Copy link

Thanks for adding this! on the create asset model page, it states: "Accepted filetypes are jpg, webp, png, gif, and svg. Max upload size allowed is 32M."

Probably would help users to know to add avif in that comment so they know it's now supported. Also any other pages that reference this similar comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants