Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2FA reset log entry #14469

Merged
merged 7 commits into from Mar 21, 2024
Merged

Added 2FA reset log entry #14469

merged 7 commits into from Mar 21, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 20, 2024

This logs a 2FA reset request to the action log. I don't think this needs to be in the admin logs, since no sensitive data is conveyed.

It also handles an issue where the reset button was being displayed even when the user didn't have 2FA set up.

Screen.Recording.2024-03-20.at.11.56.13.PM.mov

Activity Report

Screenshot 2024-03-20 at 11 58 03 PM

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

This pull request has been linked to Shortcut Story #19515: Add log for 2fa reset.

Copy link

what-the-diff bot commented Mar 20, 2024

PR Summary

  • Addition of a New Method in UsersController
    A new method named saveQuietly has been added, improving the handling of user data.

  • New Class for Actionlog
    An ActionlogPresenter class has been introduced, which will help log actions taken by users for tracking and auditing purposes.

  • Translation Updates in general.php file
    The existing two_factor_reset_help translation in the general.php file has been updated for clarity and accuracy. Additionally, a new 2FA_reset translation variable has been added as well to further support two-factor authentication dialogue.

  • Enhancements to edit.blade.php and view.blade.php files
    Especially relevant to two-factor authentication, conditional logic and relevant HTML elements have been incorporated into both the edit.blade.php and view.blade.php files. This helps to create a more responsive and user-friendly interface for managing two-factor authentication settings.

@snipe snipe changed the title Feature/sc 19515/2fa reset log Added 2FA reset log entry Mar 21, 2024
@snipe snipe merged commit 91c7180 into develop Mar 21, 2024
8 checks passed
@snipe snipe deleted the feature/sc-19515/2fa_reset_log branch March 21, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant