Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dymo Labelwriter 1933081 #14491

Merged
merged 2 commits into from Mar 26, 2024
Merged

Added Dymo Labelwriter 1933081 #14491

merged 2 commits into from Mar 26, 2024

Conversation

PP-JN-RL
Copy link
Contributor

Description

I have update the name the name to match the naming scheme of the existing labels and added another 25mm X 89mm Dymo label that is slightly longer and allows for more characters.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this on out docker instance by adding in the two new files. Works as expected.
I have also printed labels with our Dymo LabelWriter Wireless and seen no issues

  • wget files into current release docker image
  • printed labels on Dymo LabelWriter Wireless

Test Configuration:

  • PHP version: Docker Image for Snipe-IT (latest)
  • MySQL version: 8.0
  • Webserver version: Docker Image for Snipe-IT (latest)
  • OS version: Docker Host is Rocky 9

Checklist:

Fix the name of LabelWWriter_2112283 to be consistent with the existing one.
Added a longer version of the existing label (25 x 54mm vs. 25 x 89mm) due to better availability and to support longer asset names.
Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • New File for Label Generation
    A new file named LabelWriter_1933081.php has been added to the app/Models/Labels/Tapes/Dymo/ directory. This file provides features to create PDF labels efficiently. It comes with constant factors and methods specifically made for this task. The features include printing barcodes, fields, and titles.

  • File Renamed for Consistency
    The file formerly known as Label_Writer_2112283.php in the app/Models/Labels/Tapes/Dymo/ directory has been renamed to LabelWriter_2112283.php. This re-naming is to maintain a consistent naming convention across the project and ensure ease of access.

@snipe
Copy link
Owner

snipe commented Mar 26, 2024

I already fixed this :)

@snipe snipe closed this Mar 26, 2024
@PP-JN-RL PP-JN-RL changed the title Patch 1 New Labels Added Mar 26, 2024
@PP-JN-RL
Copy link
Contributor Author

Did you see that I also added another label in this PR that is slight longer than the last one?

@snipe snipe changed the title New Labels Added Added Dymo Labelwriter 1933081 Mar 26, 2024
@snipe
Copy link
Owner

snipe commented Mar 26, 2024

I hadn't - thanks!

@snipe snipe reopened this Mar 26, 2024
@snipe snipe merged commit ccf9457 into snipe:develop Mar 26, 2024
14 checks passed
@PP-JN-RL PP-JN-RL deleted the patch-1 branch March 26, 2024 08:58
@snipe snipe added the labels label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants