Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signature to user print report for Accessories and Consumables #14500

Merged
merged 4 commits into from Mar 27, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Mar 26, 2024

Description

Added the signature for accessory and consumable acceptances to users' print all report.
image
Fixes # (issue)
[sc-25118]

Type of change

Please delete options that are not relevant.

  • [x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • New "Signature" Column Added to Table
    A fresh column named "Signature" has been introduced to the table in the application, aimed at providing additional and necessary information that enhances user's experience on the platform. Implementation is carried out in the 'print.blade.php' file.

Copy link

@snipe
Copy link
Owner

snipe commented Mar 26, 2024

That last fix will break the table layout though, since the header has a spot for signature. We'd have 6 table headers but potentially only 5 table columns.

Something more like

<td>
   @if (($accessory->assetlog->first()) && ($accessory->assetlog->first()->accept_signature!=''))
       <img style="width:auto;height:100px;" src="{{ accessory('/') }}display-sig/{{ $accessory->assetlog->first()->accept_signature }}">
   @endif
</td>

like we do for assets.

@snipe snipe changed the title adds accessory signature to user print report Added accessory signature to user print report Mar 26, 2024
@snipe
Copy link
Owner

snipe commented Mar 26, 2024

Per [SC-20725] can we add the signature column for the other types of items as well?

Copy link

@Godmartinz
Copy link
Collaborator Author

Godmartinz commented Mar 26, 2024

@snipe Whoops on the if statement--corrected.
This PR is for [SC-25118] but yea i can add 20725 to this.

@Godmartinz Godmartinz requested a review from snipe March 26, 2024 18:11
@Godmartinz Godmartinz marked this pull request as draft March 26, 2024 18:26
@snipe
Copy link
Owner

snipe commented Mar 26, 2024

Ack, I think we already have the feature from [SC-20725], don't we? If not, it's out of scope for this PR anyway. If we do have those implemented, let's make sure we're exposing those signatures in the print page as well.

@Godmartinz Godmartinz changed the title Added accessory signature to user print report Added signature to user print report for Accessories and Consumables Mar 26, 2024
@Godmartinz
Copy link
Collaborator Author

Godmartinz commented Mar 26, 2024

@snipe currently we have consumables, accessories and assets. We will need to build signing out for components and licenses. (that commit should say consumables not components..Components on the brain)

@Godmartinz Godmartinz marked this pull request as ready for review March 26, 2024 20:52
@snipe
Copy link
Owner

snipe commented Mar 26, 2024

Can you retarget this to develop?

@Godmartinz Godmartinz changed the base branch from master to develop March 27, 2024 04:06
@snipe snipe merged commit 57010b4 into snipe:develop Mar 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants