Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation around pwd_secure_complexity #14502

Merged

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds a small amount of validation around the pwd_secure_complexity field when updating settings to ensure unexpected data is not stored.

This will only pop up if users manually change the html of the form but adds a layer of protection:
Screenshot of error messages on settings page

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

This pull request has been linked to Shortcut Story #25004: Add validation around pwd_secure_complexity field.

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • Introduction of Validation Rules in Settings Controller
    The code now includes additional validation rules within the Settings controller. This simply means that the system is becoming smarter at checking data to ensure it's correct before processing it.

  • Improved Security Field Validation
    In the same controller, there's been extra validation added precisely for the field pwd_secure_complexity, responsible for password complexity. This means our system is now more careful in assessing the strength of the passwords users set, promoting better security.

  • General Validation Message Enhanced
    There's been a new general validation message added. That means if an invalid value is entered into a field, the system can notify the user in a more informative way, helping users to input data appropriately.

  • Display of Complexity Error Message
    Lastly, an error message has been implemented that will show specifically for the pwd_secure_complexity field. This will help users understand the system's password requirements better, encouraging stronger passwords and thus, better security.

What's evident from these improvements is an emphasis on enhancing password validation, ensuring users create stronger and more secure passwords, and thereby increasing the security of the whole system. It also enhances user interaction due to the improved and more informative error messages.

@snipe
Copy link
Owner

snipe commented Mar 26, 2024

Nice and straightforward - thanks!

@snipe snipe merged commit ae403da into snipe:develop Mar 26, 2024
8 checks passed
@marcusmoore marcusmoore deleted the bug/sc-25004/pwd_secure_complexity-validation branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants