Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to filter in user's assigned assets by category ID and model ID #14509

Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 27, 2024

This adds additional filters to the user's asset API endpoint that should let the API return filtered results showing only a user's assets that match a particular category or model ID.

In going through this work, I realize we have some inconsistencies in how we reference our query scopes. Many of them are quite old, and the notion of adding scopes to search on names in addition to ID numbers wasn't on our radar back then.

In v7, I hope to refactor those scope names so that they're a little clearer when the scope is looking at an ID or looking for a name search.

Copy link

This pull request has been linked to Shortcut Story #25173: Add ability to scope users/{:id}/assets by category ID.

Copy link

what-the-diff bot commented Mar 27, 2024

PR Summary

  • Improved Search Functionality in User Panel
    The additions to the file UsersController.php now allow for the application to filter search results based on category and model IDs within the user panel. This enhancement simplifies the process for users to locate their desired items swiftly by narrowing down the results according to the specific item category or model they specify.

@snipe snipe merged commit befa442 into develop Mar 27, 2024
8 checks passed
@snipe snipe deleted the feature/sc-25173/filter_assigned_user_assets_by_category_id branch March 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant