Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ldap_company Sync field and Company ldap_ou User sync #14644

Closed
wants to merge 4 commits into from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Apr 24, 2024

Description

This adds the ability to sync the company field from LDAP.
image

This also adds the ability to User sync by Company OU, adding an ldap_ou column to the companies' table.
image

Therefore in LDAP settings, radio buttons have been added to toggle a selection on how to sync your OUs--
by Location or by Company. The selected radio button stays marked.
image

Because companies more than likely would be on different LDAP servers and/or a lot of users. The company sync is limited to one company at a time.
image
Locations remains multiple.
image

Fixes #12176 #10698 #12645 #10161 #12176 #4765 [sc-25411]

Type of change

Please delete options that are not relevant.

  • [ x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner April 24, 2024 20:52
@Godmartinz Godmartinz marked this pull request as draft April 24, 2024 20:52
@Godmartinz Godmartinz changed the title Ldap fmcs WIP: Ldap fmcs Apr 24, 2024
Copy link

what-the-diff bot commented Apr 24, 2024

PR Summary

  • Company Identification Enhancements
    Introduced a new system parameter ($ldap_result_company) for more convenient retrieval of LDAP-specific company settings.

  • User Table Improvements
    Added a company field to the users table, helping to enhance user categorization according to their respective companies.

  • Database Update
    Executed a database enhancement by adding an ldap_company column to the settings table, through a new migration file.

  • LDAP Setting Visibility
    The LDAP settings form within the admin panel now includes an ldap_company field for easier and more transparent adjustment of company-specific settings.

  • Usability Update for LDAP import view
    The LDAP import view now presents a selection field for companies, replacing the previous location-based selection. This is dependent on the ldap_ou_sync_type setting, optimizing the method of importing LDAP users.

@Godmartinz Godmartinz changed the title WIP: Ldap fmcs Added ldap_company Sync field and Company ldap_ou User sync Apr 25, 2024
@Godmartinz Godmartinz self-assigned this Apr 25, 2024
@Godmartinz Godmartinz marked this pull request as ready for review April 25, 2024 01:58
@Godmartinz Godmartinz marked this pull request as draft April 25, 2024 02:15
@Godmartinz Godmartinz closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant