Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LDAP pagination for user import. #1826

Merged
merged 1 commit into from Mar 25, 2016
Merged

Added LDAP pagination for user import. #1826

merged 1 commit into from Mar 25, 2016

Conversation

rho333
Copy link

@rho333 rho333 commented Mar 8, 2016

Pull request for #1825

@rtonata88
Copy link

Thanks, I have tested this and it works fine..

@snipe
Copy link
Owner

snipe commented Mar 23, 2016

Thanks, @richardhofman6. FYI, PRs are supposed to be made to the develop branch, not master, per the contributing guidelines.

@snipe snipe merged commit cf5fcdf into snipe:master Mar 25, 2016
@snipe
Copy link
Owner

snipe commented Mar 25, 2016

Hey @richardhofman6 - thanks again for this. Can you (and anybody else) take a look at https://github.com/snipe/snipe-it/blob/v3/app/Http/Controllers/UsersController.php#L1101 and confirm that I've ported over your changes to v3 correctly?

@rho333
Copy link
Author

rho333 commented Mar 27, 2016

Hi @snipe, the port looks fine - from what I've seen, I don't think the changes in v3 should make a difference to how LDAP import works. I'll do a test on my v3 demo installation soon and let you know if it works correctly.

Apologies for raising the PR to the wrong branch - will commit to the develop branch in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants