Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer again #4702

Merged
merged 8 commits into from Dec 29, 2017
Merged

Importer again #4702

merged 8 commits into from Dec 29, 2017

Conversation

dmeltzer
Copy link
Contributor

Assorted importer fixes/improvements

  • Restore importing to existing user id
  • Require a status type to be set before trying to import and provide better feedback.
  • Fix user importer/emails
  • Components should be unique on serial, not name
  • Properly set the location_id when importing now that we've denormed it.

@dmeltzer dmeltzer requested a review from snipe as a code owner December 28, 2017 19:16
@dmeltzer
Copy link
Contributor Author

Added case-insensitive matching of column names in the importer field mapping, as well as automatically remapping fields when import type changes. It could still benefit from some fuzzy matching, but we're getting closer.

@snipe snipe merged commit f16ce09 into snipe:develop Dec 29, 2017
@dmeltzer dmeltzer deleted the importer-again branch May 1, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants