Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8462 - move accessory notes into pivot table #8596

Merged
merged 3 commits into from Oct 23, 2020

Conversation

snipe
Copy link
Owner

@snipe snipe commented Oct 23, 2020

This should fix the notes issue reported in #8462, and adds a check-out date for the listings.

The migration is a little gross, as we have to find the matching rows from the action_logs table and copy them over into the accessories_users table, but it seems to get the job done without having us consistently hammering the action_logs table, which can get kinda big over time.

@uberbrady I'd love your eyes on this, if you can pull down this branch. To test this, check out a few accessories to a few different users before pulling the branch, then pull the branch down, and run migrations.

@snipe snipe requested a review from uberbrady October 23, 2020 07:48
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and makes a lot of sense. The best way to associate a particular checkout of a particular accessory at a particular time with a particular note - is to put the note in the actual join record itself.

@snipe snipe merged commit 2aa8e1e into develop Oct 23, 2020
@snipe snipe deleted the fixes/8462_move_accessory_notes branch October 23, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants