-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #9813: Duplicate function accept-asset #9822
Conversation
@inietov Can you test this PR for me when you get a moment? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clean up on our routes. Looks good to me, works as described in my local, and I actually like more how it looks the acceptance screen now.
Thanks again for your time putting this together!!.
As reqested in the roadmap post, I also created a v6 PR #9857 |
I there anything else to do, to get the pr merged? |
@dampfklon Sorry this took so long. I'm seeing some merge conflicts that one of us will have to get handled before I can merge :( |
rearrange eula on top small design fixes
84ac9d0
to
0d49fc3
Compare
@snipe Took me also some time to fix the merge conflicts. It's now fixed. |
Would be nice if this would make it into the v6 release. |
Description
The old and not longer used route https://demo.snipeitapp.com/account/view-assets/9 got remove with its controller functions and view.
The new view has now localization support, no new strings were needed. I also switch the position of the Accept/Decline Ratio Buttons and the Eula, so the user first reads the Eula and then selects Accept or Decline and if active directly below signs it.
Lastly I made small design changes to the view.
Preview after the changes:
https://imgur.com/Aj9u0Y6
Fixes #9813
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: