Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some problem in taggingJS #1

Closed
KiarashS opened this issue Mar 23, 2014 · 5 comments
Closed

some problem in taggingJS #1

KiarashS opened this issue Mar 23, 2014 · 5 comments
Assignees

Comments

@KiarashS
Copy link

Hi,
first, very thanks for great taggingJS plugin.

first issue:you must prevent duplicate tag.
second issue:after first line in textbox is fulled,next line will drop out of textbox While height of textbox must be grow, also between each line must exist little gap.

tag

@sniperwolf sniperwolf self-assigned this Mar 23, 2014
@sniperwolf
Copy link
Owner

Hi Kiarash,

thank you for this feedback, I really appreciate that.

In my mind, the first issue is a feature that I can add to taggingJS like an option, so you can enable no_duplicate simply passing a JavaScript object with no_duplicate property set true (ex. $("#fooTagField").tagging({"no_duplicate": true});). I will work on that, maybe adding it with other useful options.

The second one is a problem that concerns the example, and it is due to the fact that in tag-basic-style.css file, the height property of class .tagging (on line 6) has a fixed pixel value. Just put auto to fix that CSS bug.

I will close this issue when I will fix the first one.

sniperwolf added a commit that referenced this issue Mar 23, 2014
sniperwolf added a commit that referenced this issue Mar 23, 2014
sniperwolf added a commit that referenced this issue Mar 23, 2014
sniperwolf added a commit that referenced this issue Mar 23, 2014
sniperwolf added a commit that referenced this issue Mar 23, 2014
@sniperwolf sniperwolf reopened this Mar 23, 2014
@KiarashS
Copy link
Author

ok, thats very good. thats a good idea which any customization available via options.

@sniperwolf
Copy link
Owner

Hi @Kiyarash,

finally, I updated the plugin as said. You can read all the news on the new README.

Let me know what you think ;)

Thanks again for the messages.

@KiarashS
Copy link
Author

That is Awesome. this is very good news. now taggingJS works like a worm !!!
Also i have two offer for now, add a hover class to tag items and several theme to taggingJS.

@sniperwolf
Copy link
Owner

Yeah @Kiyarash, these are very good ideas.

Please, open a new enhancement issue with that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants