Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with stop words in DeterministicIntentParser #789

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

adrienball
Copy link
Contributor

Description:
The deterministic intent parser skips words that are in the stop words list. However, words that are both in the stop words list and in the list of entity values should not be skipped, and this is the goal of this PR.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball merged commit b8466e7 into develop Apr 26, 2019
@adrienball adrienball deleted the fix/stop-words branch April 26, 2019 09:26
@adrienball adrienball mentioned this pull request Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants