Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings and improve errors #821

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Add warnings and improve errors #821

merged 4 commits into from
Jul 9, 2019

Conversation

adrienball
Copy link
Contributor

Description:

  • Add some warning logs
  • Raise proper error when attempting to load resources with bad requirements

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball requested a review from ClemDoum July 5, 2019 09:12
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #821 into develop will increase coverage by 0.12%.
The diff coverage is 90%.

@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
+ Coverage    88.53%   88.65%   +0.12%     
===========================================
  Files           76       76              
  Lines         4615     4620       +5     
  Branches       896      900       +4     
===========================================
+ Hits          4086     4096      +10     
+ Misses         394      390       -4     
+ Partials       135      134       -1

@adrienball adrienball merged commit d6bb864 into develop Jul 9, 2019
@adrienball adrienball deleted the task/add-warnings branch July 9, 2019 08:33
@ClemDoum ClemDoum mentioned this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants