Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hardcode API url in api/client/client.go #6

Closed
rogerthebest opened this issue Jul 21, 2021 · 1 comment · Fixed by #22
Closed

Do not hardcode API url in api/client/client.go #6

rogerthebest opened this issue Jul 21, 2021 · 1 comment · Fixed by #22
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v1.0.0

Comments

@rogerthebest
Copy link
Contributor

rogerthebest commented Jul 21, 2021 •
edited

Ideally, this would be configurable, I assume should be possible via ENV var and/or flag during build.

Might also make sense to make this configurable by the user, however that would be a separate issue.
@rogerthebest rogerthebest added enhancement New feature or request help wanted Extra attention is needed labels Jul 21, 2021
@rogerthebest rogerthebest added this to the v1.0.0 milestone Jul 21, 2021
@rickymarcon
Copy link
Contributor

I believe 192e81c closes this now.

@rickymarcon rickymarcon mentioned this issue Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

build: move OTS base URL into build config sniptt-official/ots
2 participants
@rickymarcon @rogerthebest