Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move OTS base URL into build config #22

Merged
merged 1 commit into from Aug 11, 2021
Merged

build: move OTS base URL into build config #22

merged 1 commit into from Aug 11, 2021

Conversation

rickymarcon
Copy link
Contributor

Closes #6

@rickymarcon rickymarcon added this to the v1.0.0 milestone Aug 11, 2021
slavovojacek
slavovojacek reviewed Aug 11, 2021
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
@rickymarcon rickymarcon marked this pull request as ready for review August 11, 2021 13:34
slavovojacek
slavovojacek approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@slavovojacek slavovojacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@slavovojacek slavovojacek enabled auto-merge (squash) August 11, 2021 19:49
@slavovojacek slavovojacek added the enhancement New feature or request label Aug 11, 2021
@slavovojacek slavovojacek merged commit 66e3c30 into main Aug 11, 2021
@slavovojacek slavovojacek deleted the build/config branch August 11, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavovojacek slavovojacek slavovojacek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Do not hardcode API url in api/client/client.go
2 participants
@rickymarcon @slavovojacek