chore: update to go v1.22 and other deps and fix lint errors

.github/workflows/ci-workflow.yml

@@ -12,9 +12,9 @@ jobs:
           go-version: 1.22
       - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v4
         with:
-          version: v1.52.2
+          version: v1.56.2
           args: --verbose
 
   test:

.golangci.yml

@@ -63,3 +63,4 @@ linters:
 
 run:
   issues-exit-code: 1
+  timeout: "5m"

.vscode/settings.json

@@ -5,6 +5,7 @@
   ],
   "cSpell.words": [
     "bodyclose",
+    "cobrass",
     "cubiest",
     "deadcode",
     "depguard",
@@ -20,6 +21,7 @@
     "gocyclo",
     "gofmt",
     "goimports",
+    "gomega",
     "gomnd",
     "gosec",
     "gosimple",
@@ -34,13 +36,15 @@
     "nakedret",
     "nolint",
     "nolintlint",
+    "onsi",
     "pixa",
     "prealloc",
     "repotoken",
     "resq",
     "sidewalk",
     "skeletor",
     "smaug",
+    "snivilised",
     "staticcheck",
     "structcheck",
     "stylecheck",

src/app/command/bootstrap.go

@@ -94,8 +94,7 @@ func (b *Bootstrap) configure(options ...ConfigureOptionFn) {
 		//
 		viper.AddConfigPath(home)
 		viper.SetConfigType("yaml")
-		configName := fmt.Sprintf("%v.yml", ApplicationName)
-		viper.SetConfigName(configName)
+		viper.SetConfigName(fmt.Sprintf("%v.yml", ApplicationName))
 	}
 
 	viper.AutomaticEnv() // read in environment variables that match

src/app/command/bootstrap_test.go

@@ -1,8 +1,8 @@
 package command_test
 
 import (
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/snivilised/extendio/xfs/utils"
 	"github.com/snivilised/scorpio/src/app/command"
 	"github.com/snivilised/scorpio/src/internal/helpers"

src/app/command/command_suite_test.go

@@ -3,8 +3,8 @@ package command_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 )
 
 func TestCommand(t *testing.T) {

src/app/command/pool-cmd.go

@@ -31,7 +31,7 @@ func buildPoolCommand(container *assistant.CobraContainer) *cobra.Command {
 
 				// optionally invoke cross field validation
 				//
-				if xv := ps.CrossValidate(func(ps *react.PoolParameterSet) error {
+				if xv := ps.CrossValidate(func(_ *react.PoolParameterSet) error {
 					return nil
 				}); xv == nil {
 					options := []string{}

src/app/command/pool_cmd_test.go

@@ -3,8 +3,8 @@ package command_test
 import (
 	"fmt"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 
 	xi18n "github.com/snivilised/extendio/i18n"
 	"github.com/snivilised/extendio/xfs/utils"

src/app/command/root-cmd_test.go

@@ -1,8 +1,8 @@
 package command_test
 
 import (
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 
 	"github.com/snivilised/extendio/xfs/utils"
 	"github.com/snivilised/scorpio/src/app/command"

src/app/react/pipeline.go

@@ -36,7 +36,7 @@ func (p *pipeline[I, O]) produce(
 	provider ProviderFn[I],
 	jobChSize int,
 ) {
-	p.cancel = func(ctx context.Context, delay time.Duration, cancellations ...context.CancelFunc) {
+	p.cancel = func(_ context.Context, delay time.Duration, cancellations ...context.CancelFunc) {
 		go CancelProducerAfter[I, O](
 			delay,
 			cancellations...,

src/app/react/pool-entry-point.go

@@ -28,6 +28,7 @@ func EnterPool(ps *PoolParameterSet) error {
 	pipe.produce(ctx, func() TestJobInput {
 		recipient := rand.Intn(len(audience)) //nolint:gosec // trivial
 		sequence++
+
 		return TestJobInput{
 			sequenceNo: sequence,
 			Recipient:  audience[recipient],

src/i18n/i18n_suite_test.go

@@ -3,8 +3,8 @@ package i18n_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 )
 
 func TestI18n(t *testing.T) {

src/internal/log/new-logger.go

@@ -16,6 +16,7 @@ func NewLogger(info *LoggerInfo) Ref {
 			if info.Path == "" {
 				panic(i18n.NewInvalidConfigEntryError(info.Path, "-"))
 			}
+
 			ws := zapcore.AddSync(&lumberjack.Logger{
 				Filename:   info.Path,
 				MaxSize:    info.Rotation.MaxSizeInMb,
@@ -29,6 +30,7 @@ func NewLogger(info *LoggerInfo) Ref {
 				ws,
 				info.Level,
 			)
+
 			return zap.New(core)
 		}, func() Logger {
 			return zap.NewNop()