Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and tested for 3.8 #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed and tested for 3.8 #28

wants to merge 4 commits into from

Conversation

fadein
Copy link

@fadein fadein commented Feb 5, 2020

No description provided.

@snoack
Copy link
Owner

snoack commented Feb 5, 2020

This merge request seems incomplete. It doesn't add Python 3.8 to tox.iniand .travis.yml, and the changes break on other Python versions (see the CI status).

@insignification
Copy link

@snoack - did you give up on my pull requests already? As you recall, #28 provides stable py38 support, together with stabler support for other py versions (less crashes/bugs/etc, with tests).

@rh314
Copy link

rh314 commented Oct 11, 2020

EDIT: ignore the comment below, I see the code.co_kwonlyargcount fix was already introduced here: https://github.com/snoack/python-goto/blame/acbe736221d2238df3d09beab457d0bb19d05812/goto.py#L55

OUTDATED COMMENT: Ah! Was going to create a similar PR. Discovered the same fix. (the extra code.co_kwonlyargcount parameter in 3.8)
@snoack, please consider looking at this PR again 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants