Sharepoint branch updated to work on M1/M2 macs #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran npm update --save.
when running npm run build you'll get a quite a few errors that talk about missing type definition files... They are not not missing... just adding one line "noImplicitAny": false in tsconfig.json file suppresses those messages.
src/LoginModules.ts:14:20 - error TS2503: Cannot find namespace 'puppeteer'. src/TokenCache.ts:60:20 - error TS2503: Cannot find namespace 'puppeteer'. and... src/TokenCache.ts:99:24 - error TS2339: Property 'waitFor' does not exist on type 'Page'. These are fixed by simple oneliner changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @snobu,
I am fairly new to using gitHub and I might have created a mess here by creating an issue, forking, commenting and pulling and I really cant figure out git!!! So please forgive me!
I spent a bit of time figuring this out and fixing a few things and got this working and I wanted to help others out so here you are with my notes and changes. I hope that this links to this issue #489 .