Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example on how to add correlation_id in uvicorn access log #77

Merged
merged 2 commits into from
Dec 14, 2023
Merged

add example on how to add correlation_id in uvicorn access log #77

merged 2 commits into from
Dec 14, 2023

Conversation

nesies
Copy link

@nesies nesies commented Dec 12, 2023

Closes #76

@nesies nesies changed the title add_example_add_correlation_id_to_uvicorn_access_log add example on how to add correlation_id in uvicorn access log Dec 12, 2023
sondrelg
sondrelg reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've made two suggestions to (in my mind) streamline the explanation a bit 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sondrelg
Copy link
Member

Thanks @nesies!

@sondrelg sondrelg merged commit 93e1ea1 into snok:main Dec 14, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondrelg sondrelg sondrelg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

question: how to add correllation_id in http access log ?
2 participants
@nesies @sondrelg