Add sentry integration-step to worker prerun celery signal #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKs
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
🍻
I fixed the failing test, and fixed made sure the test_dont_set_transaction_id actually passes for the right reasons. The tests failed because of propagate=False, caplog can't catch those logs. There's two solutions, either override_settings and change the Django setting, or simply do this:
logger = logging.getLogger('django_guid.celery')
logger.addHandler(caplog.handler)Also removed a file called tests/unit/.coverage.Sondres-MBP.88325.438243, FYI!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds functionality for adding Sentry transaction_id's in the new Celery integration.
I'm not sure why the one test is failing @JonasKs - perhaps you could take a look at it? Also, feel free to change changelog/docs as well if there's anything you would prefer to word differently.