Merge pull request #98 from wyuenho/fix-96

Fix #96 none handling for select and extend-select
snok · Jul 13, 2022 · 9bcbefe · 9bcbefe
2 parents b4bfe9a + 3e454d2
commit 9bcbefe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/flake8_type_checking/plugin.py b/flake8_type_checking/plugin.py
@@ -114,19 +114,22 @@ def should_warn(self, code: str) -> bool:
             logger.info('Options not provided to flake8-type-checking, optional warning %s selected.', code)
             return False
 
+        selected_rules = tuple(
+            list(self.options.select or [])
+            + list(self.options.extended_default_select or [])
+            + list(self.options.extend_select or [])
+            + list(self.options.enable_extensions or []),
+        )
+
         for i in range(3, len(code) + 1):
-            if code[:i] in (
-                self.options.select
-                + list(self.options.extended_default_select)
-                + (self.options.enable_extensions or [])
-            ):
+            if code[:i] in selected_rules:
                 # Warn if opted-in
                 return True
 
         # Don't warn if not opted-in
         logger.info(
             'Optional warning %s not present in selected warnings: %r. Not running it at all.',
             code,
-            self.options.select,
+            selected_rules,
         )
         return False
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -30,6 +30,7 @@ def _get_error(example: str, *, error_code_filter: Optional[str] = None, **kwarg
     if error_code_filter:
         mock_options = Mock()
         mock_options.select = [error_code_filter]
+        mock_options.extend_select = None
         # defaults
         mock_options.extended_default_select = []
         mock_options.enable_extensions = []