#53 use InvariantCulture to display values #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there is no generic ToString overload that accepts a CultureInfo. To circumvent this problem, I have to highjack the current threads CurrentCulture for a short period in time, generate the string value and switch the culture back. There may be other places where it would be better to use the InvariantCulture, but this is the one I was primarily concerned about. Affected Property types are at least: - DateTime values - any numbers with a decimal separator (float, double, decimal) - anything that uses those numbers as part of their toString() implementation, like Geometry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there is no generic ToString overload that accepts a CultureInfo. To circumvent this problem, I have to highjack the current threads CurrentCulture for a short period in time, generate the string value and switch the culture back.
There may be other places where it would be better to use the InvariantCulture, but this is the one I was primarily concerned about.
Affected Property types are at least:
Tackles issue #53